docs: document the CI-artifact route for the release archive - #323
Merged
Conversation
The local export is the step most likely to be the one a machine cannot do. R8 is the heaviest task in the build, and short of memory it does not fail cleanly -- it kills the daemon, and the message names neither memory nor R8 as the cause. v2.32.6 hit this at both -Xmx2048m and -Xmx1536m and the archive was assembled from the tag job's artifacts instead. That substitution is sound: `release` runs the same task on the same tagged commit with the same signing key. Writing it down so the next person does not have to decide under pressure whether it counts, and so the two things it changes are visible -- verification now runs after the tag rather than before it, and workflow artifacts expire in 30 days. Commands verified against the v2.32.6 archive: the run lookup resolves, and the notes loop reproduces the archived file exactly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a subsection to
docs/RELEASE.md§ Release Export covering what to do when:app:exportReleaseToBuildDrivecannot run locally.The local export stays the default and the section says so. But it is the step most likely to be the one a given machine cannot do:
minifyReleaseWithR8is the heaviest task in the build, and short of memory it does not fail cleanly — it kills the Gradle daemon, and the message names neither memory nor R8. v2.32.6 hit this at both-Xmx2048mand-Xmx1536mwith ~1.7 GB free, and the archive came from the tag job's artifacts instead.That substitution is sound —
releaseruns the same task on the same tagged commit with the same signing key — but it was decided ad hoc during a release, which is the wrong time to be deciding whether something counts. The section covers the symptom and how to recognise it, the download and naming, assembling the notes file from the fastlane changelogs, verifying withverify-release-export.ps1, and ajarsignercheck for the release certificate (the one property the local build gives for free and this route does not).It also names the two things this route changes:
Commands were verified against the v2.32.6 archive: the run lookup resolves to
31891151897, and the notes loop reproducesmarkleaf-v2.32.6-vc128-release-notes.txtexactly (Compare-Object→ no differences).No change to the PowerShell quoting guidance —
-Pmarkleaf.requireReleaseSigning=trueis already documented as needing quotes in § Local Signed Release Build, which is what I should have followed.🤖 Generated with Claude Code